search

plutoo / protobuf-csharp-port

Automatically exported from code.google.com/p/protobuf-csharp-port
Other
0 stars 0 forks source link

Support for negative enum values #19

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

looking at these changes in java 2.4.1:
http://code.google.com/p/protobuf/source/detail?r=381

It appears we have the same issue, writing a raw32variant.  In fact this should 
use the zig-zag variant form.  i.e. computeInt32SizeNoTag, WriteInt32

This should be addressed in both CodedOutput.WriteEnum, and ComputeEnumSizeNoTag

Original issue reported on code.google.com by Grig...@gmail.com on 19 Aug 2011 at 3:34

GoogleCodeExporter commented 9 years ago 
Actually that is not the zig-zag form, it's sign-extended, (64 bit negative).

Original comment by Grig...@gmail.com on 19 Aug 2011 at 3:36

GoogleCodeExporter commented 9 years ago 
Fix pending review:
http://code.google.com/p/protobuf-csharp-port/source/list?name=issue-19

Original comment by Grig...@gmail.com on 10 Sep 2011 at 3:22

GoogleCodeExporter commented 9 years ago

Original comment by Grig...@gmail.com on 16 Sep 2011 at 6:28