search

plutoo / protobuf-csharp-port

Automatically exported from code.google.com/p/protobuf-csharp-port
Other
0 stars 0 forks source link

Generated nested static Types class should be partial #49

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The generated protobuf code looks a lot like:
public static partial class Umbrella {
    public sealed partial class Outer {
        public static class Types {
            public sealed partial class Inner {

It is not possible to extend the Inner partial class as the Types class is not 
marked as partial.

I believe line 245 of ProtoGen/MessageGenerator.cs needs changing.

What steps will reproduce the problem?
1. Run ProtoGen on a .proto file (with nested messages)
2. Look at the generated

What version of the product are you using? On what operating system?
2.4.1.473 on Windows 7-64bit

Original issue reported on code.google.com by da...@smews.com on 4 Sep 2012 at 7:59

GoogleCodeExporter commented 9 years ago 
Fixed 
http://code.google.com/p/protobuf-csharp-port/source/detail?r=dfd0f5525f66b699ab
72c2d1662ba196dca11adf

Original comment by Grig...@gmail.com on 10 Oct 2012 at 8:32

GoogleCodeExporter commented 9 years ago

Original comment by Grig...@gmail.com on 10 Oct 2012 at 9:52

GoogleCodeExporter commented 9 years ago 
I'm affected by this, but there's been no release for quite some time 
now...makes it difficult when you're using NuGet.

Original comment by kent.boo...@gmail.com on 3 May 2013 at 10:58

GoogleCodeExporter commented 9 years ago 
Kent,

I'll work on a release soon.

Original comment by Grig...@gmail.com on 7 May 2013 at 7:45

GoogleCodeExporter commented 9 years ago 
Release 2.4.1.521 has been pushed.

Original comment by Grig...@gmail.com on 7 May 2013 at 10:00

GoogleCodeExporter commented 9 years ago 
Thanks!

Original comment by kent.boo...@gmail.com on 17 May 2013 at 12:26