Patch for /src/ProtocolBuffers/Properties/AssemblyInfo.cs

[GoogleCodeExporter]

Make it work in partially trusted environment

Original issue reported on code.google.com by peter.sm...@gmail.com on 29 Jul 2014 at 2:52

Attachments:

• AssemblyInfo.cs.patch

[GoogleCodeExporter]

Hi Peter,

Before I can apply the patch, I'm afraid I'll need to you to sign (preferrably 
electronically) the Google CLA - either the individual one:
https://developers.google.com/open-source/cla/individual

or the corporate one:
https://developers.google.com/open-source/cla/corporate

If you could ping this issue when you've done so, that'd be great. I'll have a 
look at the patch in the meantime.

Original comment by jonsk...@google.com on 29 Jul 2014 at 3:13

[GoogleCodeExporter]

Done

Original comment by peter.sm...@gmail.com on 29 Jul 2014 at 7:10

[GoogleCodeExporter]

Okay, thanks.

AllowPartiallyTrustedCallers makes perfect sense, but I don't know about the 
others:

- We don't perform any security-critical operations, so I wouldn't *expect* 
SecurityCritical to be required in general. It *would* be needed for the binary
serialization code in CustomSerialization... are you happy with me just applying
it to the GetObjectData methods?

- SecurityRules is only in .NET 4+, whereas protobuf is still targeting .NET 
3.5, and is usually only for compatibility reasons. Again, I wouldn't expect 
that to be required.

Original comment by jonathan.skeet on 30 Jul 2014 at 8:40

[GoogleCodeExporter]

Hi,

Yes, you are right. Just applying the SecurityCritical at chosen points should 
be enough; and also SecurityRules are not needed in this case - the APTCA do 
apply thought.

Thanks in advance if you can apply this,
Peter

Original comment by peter.sm...@gmail.com on 28 Aug 2014 at 9:20

[GoogleCodeExporter]

This should now be fixed in revision d3c7c6a1e16e.

Could you check that it works for you?

Original comment by jonathan.skeet on 9 Sep 2014 at 10:10

• Changed state: Fixed

[GoogleCodeExporter]

Yes, I can confirm it's what I expected - thank you.

Original comment by peter.sm...@gmail.com on 10 Sep 2014 at 2:32

[GoogleCodeExporter]

Hi,

Just out of curiosity, is there an official release expected any time soon?

Thanks,
Peter

Original comment by peter.sm...@gmail.com on 6 Jan 2015 at 9:42

[GoogleCodeExporter]

Ccing Roger who normally does the release to Nuget - I don't have any immediate 
plans, but I don't see any harm in doing an extra release for this...

Original comment by jonathan.skeet on 6 Jan 2015 at 10:02

[GoogleCodeExporter]

I'll work on getting one together in the January time frame.  I'd like to 
automate with TeamCity as I've been doing with other projects. 

Original comment by Grig...@gmail.com on 7 Jan 2015 at 3:48

[GoogleCodeExporter]

Great - thanks very much. I may take a look through the rest of our issues list 
and see if there are any ones I could quickly knock out before a release. (I 
started looking at multifile support, but it ends up getting pretty hairy.)

Original comment by jonathan.skeet on 7 Jan 2015 at 8:44