Feat/email type - Githubissues

plutov / formulosity

Self-hosted Surveys as Code platform.

https://formulosity.vercel.app

MIT License

181 stars 20 forks source link

Feat/email type #21

Closed anveshthakur closed 1 month ago

anveshthakur commented 1 month ago

hi @plutov,

I have added the new question type email which is mentioned in the issue #20, I've tested the code from the UI It is working fine. Please let me know if there is any change required or you want me to add any other validations to it.

Thanks!

vercel[bot] commented 1 month ago

@anveshthakur is attempting to deploy a commit to the formulosity Team on Vercel.

A member of the Team first needs to authorize it.

anveshthakur commented 1 month ago

Hi @plutov, I’ve added ozzo/validation to include proper checks on the email as requested. I accidentally marked the conversation as resolved, but I’m happy to make further changes if needed.

plutov commented 1 month ago

Thanks @anveshthakur the PR looks good. I will test it on my machine once I have a bit more time.

anveshthakur commented 1 month ago

sure @plutov, thanks!

plutov commented 1 month ago

Thanks @anveshthakur your change is now in the latest release!

plutov commented 1 month ago

@anveshthakur I only noticed that the tests have failed but fixed those.

plutov commented 1 month ago

@anveshthakur I also noticed that email is not shown on the response page.