search

pluvial / node-zig

MIT License
21 stars 2 forks source link

Rewrite in pure node to support Windows. #2

Closed calavera closed 2 years ago

calavera commented 2 years ago

It adds two dependencies, but I think it's worth making it work for any OS.

Fixes #1

Signed-off-by: David Calavera david.calavera@gmail.com

calavera commented 2 years ago

@jpaquim I've made those updates, let me know what you think.

jpaquim commented 2 years ago

LGTM, have you had the chance to test on Windows? I just tested on Linux and it doesn't seem to be working, the tar.xz file seems to be downloaded to the bin folder, but the binary is not extracted, and then the zig.js script always fails. It also didn't seem to detect my system zig correctly...

I can look into the code tomorrow and try to see where it may be failing, but let me know if you happen to have a clue on what may be causing this.

jpaquim commented 2 years ago

Hey @calavera, not sure if you had the chance to further develop/test this, I can take another look through the PR if you want 🙂

calavera commented 2 years ago

nope, I ended up not using it.