search

pluvial / svelte-adapter-deno

A SvelteKit adapter for Deno
https://svelte-adapter-deno.deno.dev/
MIT License
325 stars 13 forks source link

Use Original Request and Response #19

Closed TheHadiAhmadi closed 2 years ago

TheHadiAhmadi commented 2 years ago

https://github.com/sveltejs/kit/pull/3384

today I worked on solving this issue by dropping oak and using Deno.listen....

https://github.com/TheHadiAhmadi/svelte-adapter-deno

TheHadiAhmadi commented 2 years ago

here is a demo which uses latest sveltekit version https://sveltekit.deno.dev https://github.com/TheHadiAhmadi/sveltekit-deno

jpaquim commented 2 years ago

Thank you, looks pretty good! I was thinking of removing Oak as well, the only reason I didn't do it was due to there being non-negligible logic in their response.send() function, including etag generation: https://github.com/oakserver/oak/blob/main/send.ts

Would you be interested in opening a PR or are you thinking of maintaining you own fork?

TheHadiAhmadi commented 2 years ago

I am Interested on opening PR, please check #20 and tell me what do you think.

I don't know much about etag and oak's response.send(), using Deno.readFile was suggested in deno deploy docs. deno's std file server is doing something with etag, also handles content-type