search

pluvial / svelte-adapter-deno

A SvelteKit adapter for Deno
https://svelte-adapter-deno.deno.dev/
MIT License
313 stars 14 forks source link

Use Deno.listen and Deno.serveHttp instead of oak #20

Closed TheHadiAhmadi closed 2 years ago

TheHadiAhmadi commented 2 years ago

Hello @jpaquim

in this PR I changed many files and structure of package canged, feel free to close if it is not helpful

I added 2 more config options

  1. serverFile: this is not used but if we provide serverFile then we will only generate handler.js and not server.js
  2. filesPrefix: relative path from server.js to static and client files, this is useful when we set serverFile to a file which is in another folder. (we can merge these options and only use serverFile and calculate filesPrefix based on build folder and server file).

I tested it with @supabase/supabase-js and @popperjs/core and works fine on deno deploy

thanks

TheHadiAhmadi commented 2 years ago

close #19

jpaquim commented 2 years ago

Thanks for the PR :pray: may I ask you to maybe review it and split it into 2/3 more focused PRs? It's not very easy to review at the moment, and I'm not sure if I want to diverge so much from adapter-node and the other official adapters. In the previous discussion you mentioned Deno's file server for etag generation, but you're not using it here right?

TheHadiAhmadi commented 2 years ago

Yes I didn't used deno file server in this PR, but in #21 I used it.

please review #21 and let me know what do you think