plz / E-Series-Graphite-Grafana

Collect Metrics from NetApp E-Series Storage appliances and dispatch them to graphite.
Apache License 2.0
13 stars 6 forks source link

customized dashboard for multiple E-Series systems #14

Closed chvvkumar closed 5 years ago

chvvkumar commented 5 years ago

Changed the chart metric aliases to show e-series names in case multiple e-series systems are selected on the same dashboard drop-down menu.

Also moved the pie chart to the top and made both cache statistics panels into gauges.

eser

plz commented 5 years ago

Thanks for the Pull Request, I'll review it and get back to you.

chvvkumar commented 5 years ago

Thanks for the Pull Request, I'll review it and get back to you.

Thanks!

plz commented 5 years ago

Hey @chvvkumar

Sorry for my delays processing your PR. I have gone through it, and incorporated some of your ideas, but not fully merged your new Dashboard. Please check what I just published https://github.com/plz/E-Series-Graphite-Grafana/commit/47f70b334855ee5c5e9e9ffc896de0e7c962ad8b and let me know if its OK to close this PR.

Thanks!

chvvkumar commented 5 years ago

@plz

Thank you for the update. You can close this PR.

I do have one suggestion though. It may be helpful to add a blurb about requiring the pie chart plugin in the readme since if I remember correctly, the pie chart plugin is not installed in Grafana by default. A link to the plugin should suffice as the plugin documentation has steps on installing it.

https://grafana.com/plugins/grafana-piechart-panel

plz commented 5 years ago

Thanks again, done via https://github.com/plz/E-Series-Graphite-Grafana/commit/873b70f9b6b72a69b4ef2091a302a4512ab5d112