pm4py / pm4py-core

Public repository for the PM4Py (Process Mining for Python) project.
https://pm4py.fit.fraunhofer.de
GNU General Public License v3.0
722 stars 286 forks source link

Missing process name while parsing BPMN XML #437

Closed ww917352 closed 1 year ago

ww917352 commented 1 year ago

Dear all,

I found out that in

https://github.com/pm4py/pm4py-core/blob/a199fbbc68637cf453d27f317e91c78a0269e599/pm4py/objects/bpmn/importer/variants/lxml.py#L42C29-L43C43

only the process ID is fetched while the process name is left out.

Is this intentional or do I have wrong understanding here?

Thank you!

Cheers, Wei

fit-alessandro-berti commented 1 year ago

Dear @ww917352

Generally the name of the BPMN is not essential for our purposes. In any case, thanks for signaling, we'll provide a correction for that.

ww917352 commented 1 year ago

Thank you a lot. Would you please link this issue to the PR when it is ready?

fit-alessandro-berti commented 1 year ago

Dear @ww917352

See https://github.com/pm4py/pm4py-core/commit/189ab5112aaf463fbd4a395561b43a1f152942fd

ww917352 commented 1 year ago

Thanks a lot! Have a great week ahead.