Intuitive CSV Import - Githubissues

pm4py / pm4py-core

Public repository for the PM4Py (Process Mining for Python) project.

https://pm4py.fit.fraunhofer.de

GNU General Public License v3.0

722 stars 286 forks source link

Intuitive CSV Import #70

Closed lsabi closed 5 years ago

lsabi commented 5 years ago

Hi,

If one is using the csv import functionality and needs to import a dataframe, apply some conversions/filtering and then convert it into an event log, one has to import two different modules.

My question is, wouldn't be more intuitive to have all the import functionalities within the same module?

Thanks

Javert899 commented 5 years ago

To solve your problem, while leaving door open for different dataframe managers than Pandas, the following methods have been added in the 'develop' branch to the factory pm4py.objects.log.importer.csv.factory:

import_dataframe_from_path
import_dataframe_from_path_wo_timeconversion
import_dataframe_from_csv_string
convert_dataframe_to_stream

So, the enhancement you suggest has been performed in the 'develop' branch. Take a look at that

lsabi commented 5 years ago

My bad, didn't see that. Any idea/estimate when the develop branch will be merged into the production?

Thanks

Javert899 commented 5 years ago

Let's say in two/three weeks!

Sincerely Alessandro

Il gio 11 apr 2019, 12:14 lsabi notifications@github.com ha scritto:

My bad, didn't see that. Any idea/estimate when the develop branch will be merged into the production?

Thanks

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pm4py/pm4py-source/issues/70#issuecomment-482055673, or mute the thread https://github.com/notifications/unsubscribe-auth/And2rt5RnwGdeLzhXGst4YmOXvcxKrvSks5vfwsBgaJpZM4cpBFo .

lsabi commented 5 years ago

Great. I'm closing the issue then.

Thanks.