search

pmadruga / react-native-clean-project

Automating the clean up of a React Native project
MIT License
1.17k stars 52 forks source link

fix: wipe iOS build should wipe all iOS build artifacts, Fixes #18 #19

Closed mikehardy closed 5 years ago

mikehardy commented 5 years ago

This string interprets the commands I posted on #18 and tests out on my build

It fixes the problem I had upgrading react-native-firebase 5.4.x to 5.5.x where some entire files were deleted but xcodebuild couldn't figure it out

mikehardy commented 5 years ago

@pmadruga I just realized I didn't update the command table in the readme for this, but honestly the string is really long, maybe it's best to just put a link to the tasks.js source line for it? Unsure what you'd like

pmadruga commented 5 years ago

Hi again @mikehardy ! Let me get back to you in a couple of days. 👍

mikehardy commented 5 years ago

Sure thing - just a note that I'm successfully using my branch with the PR changes in my project and with my teammates one by one hitting this specific DerivedData problem, it's fixing them all successfully, without seeming to break anything. So it's in use and working for me, at least. Cheers :-)

pmadruga commented 5 years ago

Looks good to me. Yes, a link to it from the documentation is good. In the future, would make sense to split it into sub-steps.

mikehardy commented 5 years ago

excellent! I seriously recommend this tool every day in support of react-native-device-info, react-native-firebase, and a few other small repos I support. Thanks for merging this in. I’m only sorry I do not / did not have more time to split it up as you mention and make it pretty. But it works! :-)