Closed codybrouwers closed 6 years ago
Wow, thanks for this. It is great! Give me a couple days to review, add some comments, and then test it in a couple of my projects. If all is good, I'll merge it. Again, thanks!
Sounds good, looking forward to your comments! :)
Hi!
I have tested and works great. Two things:
Again, thanks for the PR!
Hey @pmadruga, added those command line arguments, give it a try and let me know what you think of the defaults. Also I added the list of commands back into the README, I thought having them there was super helpful for anyone wanting to run the script, but if you want to remove them no problem, let me know.
I will take a look at tape later this week hopefully, looks interesting!
Also just saw your new contributing guidelines, I'll follow those going forward 😝👍
Thanks @CodyBrouwers ! will check on it as soon as possible (perhaps end of this week).
First off, thanks for providing this helpful package! It has benefited me a few times when trying to debug an issue and needing to run some of these tasks.
I kept running into the issue of the tasks not running asynchronous, which for most of them that isn't a problem, but when wiping the
node_modules
folder and then runningyarn install
, I found it would always do the install first then wipe the folder. So this PR should make those specific tasks execute consecutively.I also added a few other tasks to the list like optionally wiping the build folders which I've found to be helpful when debugging a build issue.
Definitely open to any suggestions or changes you want to make!