search

pmaillot / X32-Behringer

This GIT repo (C language) holds applications and utilities for the Behringer X32 and M32 mixing consoles. Additional details, documentation, implementation examples and apps can be found in my website:
https://sites.google.com/site/patrickmaillot/x32
234 stars 41 forks source link

add -s option back to XAir_Command.c #11

Closed Rippert closed 6 years ago

Rippert commented 6 years ago

I changed the code in XAir_Command.c so that the -s option works with node formatted input from a file such as a scene file. I made it so the the node formatted command had a comma followed by an appropriate number of "s" characters inserted between the path and arguments. I run this through Xcparse to handle quoted strings. Tested in OS X, and Windows (really a wine DOS terminal). Tested with simple node format commands and a complete scene (*.scn) file.

The Xcparse calls make it run a little slowly. I will look into trying to do everything with Xsprint and dealing with quotes directly in the future.

I just merged with your master branch before this change.

Rippert commented 6 years ago

Modified code to fix bug with extra "s" characters after the comma for quoted values with spaces. Got rid of the Xcparse call, but still a little slow.

Sorry about the old commits in the pull. I'm going to see if I can figure out how to get rid of them. Told you I was noob at git.

Rippert commented 6 years ago

OK, figured out the slowness. Added a test for the X32verbose flag before the CHECKXR() macro in the -s option code. Now it's as fast as the the XAir Edit app with the -t 0 -v 0 options set.

pmaillot commented 6 years ago

Thanks for contributing!