search

pmaillot / X32-Behringer

This GIT repo (C language) holds applications and utilities for the Behringer X32 and M32 mixing consoles. Additional details, documentation, implementation examples and apps can be found in my website:
https://sites.google.com/site/patrickmaillot/x32
234 stars 41 forks source link

X32CustomLayer - incorrect preamp settings #15

Closed szkudlik closed 5 years ago

szkudlik commented 5 years ago

Hi,

I'd like to report a defect in x32CustomLayer app

Problem is here: LoadCStrip(k, i); <<<< first load all data from the second channel, INCLUDING preamp settings SetASource(i, Asrc[k - 1]); <<<< than change the source

Problem is that loading the channel appies also preamp settings, the settigs are applied BEFORE the source has been changed, so in fact are applied to incorrect preamp. In result the mix is destroyed after using the app

As the app is design to change the order of the channels only, not changing the ways that the sources are physically connected, it should never change setting of any preamp. The fix is really simple, just filter out preamp settings when applying the saved channel by changing insertion mask from 63 to 62

` X32CustomLayer.c

line 121: int LibRecallMask= 62; // mask value for X32 /load and /save command

line 1123: s_len = Xsprint(s_buf, s_len, 'i', &LibRecallMask);

pmaillot commented 5 years ago

Fix accepted and applied. Thanks for your contribution! Rgds