search

pmaji / crypto-whale-watching-app

Python Dash app that tracks whale activity in cryptocurrency markets.
MIT License
609 stars 137 forks source link

Themes and Docker #121

Closed Netmonster closed 3 years ago

Netmonster commented 3 years ago

Hello,

First, I would like to say thanks for the great project.

I've made a few changes. I removed the cdn ref for your main.js. The js is now local (external hosted js could get compromised). I moved main.js file to a folder called assets. I added a theme selector to the sidebar. It has 3 modes. Light (default), Dark, Dim. I created a theme_selector js and a main.css file in the assets folder.

I created a dockerfile and docker-compose file. I added a github action workflow to create the docker file on pushed to the docker repo. You can setup a free account with docker to push the output to. Once you create an account, you need to register 2 secrets on the project DOCKERHUB_USERNAME and DOCKERHUB_TOKEN(password). You will also need to modify the docker compose file and change the image to your docker repor/imagename.

I updated the Readme file to include the theme selector feature with modes(screenshots) and added a section that list the easy docker install procedure.

Please let me know if you have any questions or concerns.

Note: this request had a python action workflow that I could not get to build it was in a previous PR. I removed it,

Thanks,

Netmonster

Netmonster commented 3 years ago

withdrawing this PR. it will be superseded by my next one.