search

pmaji / crypto-whale-watching-app

Python Dash app that tracks whale activity in cryptocurrency markets.
MIT License
605 stars 137 forks source link

Some improvements #60

Closed mifunetoshiro closed 6 years ago

mifunetoshiro commented 6 years ago

The main gist of https://github.com/pmaji/crypto-whale-watching-app/pull/31 which wasn't merged was to include the total price of a bubble, which I think is valuable information (https://i.imgur.com/8ZwXOIL.png).

I also changed the TICKERS tuple into a list, because if someone just wants to use for example ETH-USD and removes the rest, Python will consider it as a string and not a tuple, so it will return an error.

I changed n_unique_orders from float into int because this is always a full number, and saying there are e.g. "5.0" unique orders instead of "5" is redundant.

I also improved some text formatting and added rounding that @theimo1221 forgot in the ladder whale tooltips (it would say e.g. 3.000000005345 BTC).

Also changed the server IP from 0.0.0.0 to 127.0.0.1

mifunetoshiro commented 6 years ago

I'm not sure how to add this total price to the ladder whale tooltips, though, I have zero experience with pandas.

pmaji commented 6 years ago

Thanks for this @mifunetoshiro. I appreciate the clarification. I'll look this over for a merge in the evening. Adding total price to the tool-tip won't be hard for me to take care of either.

theimo1221 commented 6 years ago

@mifunetoshiro could you change it, I don´t have write access to your pull request

mifunetoshiro commented 6 years ago

@theimo1221 change what exactly?

theimo1221 commented 6 years ago

@mifunetoshiro to use minimum instead of overwrite (args(3,0,2))

Afterwards this is good to go:relaxed:

pmaji commented 6 years ago

That sounds right. @mifunetoshiro once it's changed I'll merge over.

mifunetoshiro commented 6 years ago

I f'd up with that "Merge branch 'master' into patch-1" and the last "Update app.py" undoes that. Can you just merge the first two, "Use minimum instead of overwrite" and "Update app.py" (I removed an extra space)? Or do I close this and open a new pull request?

theimo1221 commented 6 years ago

Guess we have to wait for pmaji to be awake

pmaji commented 6 years ago

@mifunetoshiro it is possible to do this manually but it can get a bit messy in my experience with git-cherrypick. Open a new pull request with the version of changes that you have tested locally and are sure are good to go. I'll close this one once I see the new one opened.