search

pmaji / crypto-whale-watching-app

Python Dash app that tracks whale activity in cryptocurrency markets.
MIT License
605 stars 137 forks source link

Color the bg above market red, below market green #95

Closed mifunetoshiro closed 6 years ago

mifunetoshiro commented 6 years ago

For #44:

bgcolor

theimo1221 commented 6 years ago

Nice workaround but it´ll be problematic for later unique color changing cause i can´t separate those 2 huge shapes from the ladders....

pmaji commented 6 years ago

@theimo1221 can you clarify what you mean by later unique color changing? You mean future JS improvements to overall aesthetic?

theimo1221 commented 6 years ago

@pmaji and @mifunetoshiro Yes I mean the JS improvements. If we change it like merged here JS won´t have the possibility to change background color. I mean JS can change color behind that shapes but it couldn´t change the shapes, without changing all laders.

mifunetoshiro commented 6 years ago

Just remove these 10 lines when the JS changes are ready. But I really don't think the unique colouring option is necessary as I said in #44. Cryptowatch and exchanges don't offer you to choose colours either (except change theme maybe), and even if they did, not many would change them. Personally I think red/green is perfect and most fitting, the same as on all exchanges...