Metric names should change "." to "_"

pmalhaire / xk6-mqtt

k6 mqtt extension

Apache License 2.0

47 stars 37 forks source link

Metric names should change "." to "_" #21

Closed rgordill closed 10 months ago

rgordill commented 12 months ago

There are some warnings regarding prometheus metric name compliance (https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels):

time="2023-09-13T17:18:01Z" level=warning msg="Metric name should only include ASCII letters, numbers and underscores. This name will stop working in k6 v0.48.0 (around December 2023)." name=mqtt.sent.messages.count

pmalhaire commented 11 months ago

Thank you for the MR. It's a breaking change existing usage will be impacted. I have to choose if I make it the default and drop the old name or make it optionnal.

rgordill commented 11 months ago

As the log says, the metrics with "." will stop working around december this year, so I guess there is little value in keeping them for just three more months. Anyway, we need the "_" for the prometheus metrics,