Change to using sobek instead of goja

pmalhaire / xk6-mqtt

k6 mqtt extension

Apache License 2.0

49 stars 37 forks source link

Change to using sobek instead of goja #31

Closed mstoykov closed 3 months ago

mstoykov commented 4 months ago

We are moving to a fork of goja under grafana org called sobek.

More info in:

https://github.com/grafana/k6/issues/3772
https://github.com/grafana/k6/issues/3773

pmalhaire commented 4 months ago

There is a lint error in this MR

mstoykov commented 3 months ago

@pmalhaire looking over at the lint issues - all of them but one predate my changes and I don't think I will try to remove the "magical numbers" as part of this automatic PR to keep this extension working.

The one lint error from these changes is on a line that will have a lint error around magical numbers once the line is split.

I will be okay with fixing that one if that is what you want.

pmalhaire commented 3 months ago

I'll fix them too, in a bit of time