codepathreview
commented
10 years ago :+1: Excellent work, Poorva, looks great. A few notes after checking out the code:
- Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
- Great job on polishing your UI to make it look like the real instagram app
- Consider using the ViewHolder pattern in your adapter
- Good use of RoundedTransformation of Picasso
- Good use of the DateUtils class for showing relative timestamps.
- Great job on implementing the advanced stories and adding photos to commentors
- Great job implementing SwipeRefreshLayout.
- Consider initializing your objects only once (listview, adapters, etc) during onCreate() instead of fetchPopularPhotos();
- Consider implementing your JSON deserializing logic in your InstagramPhoto() object.
- Consider notifying the user with a Toast or any other way in the onFailure() of your network client
- Consider adding .gitignore to your projects
One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to continue completing the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.
We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.
Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.
If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or email us support@thecodepath.com.
Best, Prerak Trivedi
P.S. Good to see you properly added the README with features completed and GIFs to your project as described in the submitting assignments guide!
Please review my Instagram viewer app. I have completed required and advanced user stories. /cc @nesquena @thecodepath