Clean-up the Mess that is FeatureFactory

pmanion0 / cs224n-pa4

GitHub repository for CS224n's PA4 - Neural Network for Named Entity Recognition

0 stars 0 forks source link

Clean-up the Mess that is FeatureFactory #14

Closed pmanion0 closed 8 years ago

pmanion0 commented 8 years ago

FeatureFactory is a mostly static class that actually gets initialized with a bunch of information like a non-static class and just appears as an essential function in many other classes. It doesn't cause problems now, but we may want to clean this up if it starts to cause issues.

Tasks:

[ ] Break out FileFactory into more descriptive classes
[ ] Replace all calls to FileFactory
[ ] Kill the beast

pmanion0 commented 8 years ago

Ended up having to do this because it was going to cause a major headache when running a bunch of configurations because it just static-o-magically wrecks chaos across tons of different classes.

121e241