search

pmarchwiak / auto-reader-view

Firefox plugin for automatically opening sites in Reader View
MIT License
25 stars 4 forks source link

Firefox Quantum compatibility #4

Open reaganch opened 6 years ago

reaganch commented 6 years ago

Any plans of revising this addon to make it compatible with Firefox Quantum (v57)?

pmarchwiak commented 6 years ago

Yes, I've been working on it here and there when I get some spare time. Let me know if you're willing to help out or test and I can try to get a branch up with the current version.

reaganch commented 6 years ago

Would love to help test. Would need instructions on how to build the addon from your source code though.

pmarchwiak commented 6 years ago

@reaganch I released a new version of the addon, 1.0.2, that's compatible with Quantum. It depends on an API method only available in v58 so you'll have to use Firefox Beta, Developer or Nightly to test. Feel free to comment here or file issues for any problems you find. Thanks for the help!

reaganch commented 6 years ago

Thanks. I'm running Firefox Beta right now, which is still at v57. Will install this as soon as it updates to v58 and test. Although I'm a bit unclear on how to install the addon to test. The zip file I download from the "Releases" section contains no xpi files.

pmarchwiak commented 6 years ago

Ah, you're right. Currently Beta is at v57, which unfortunately won't work with the addon due to the aforementioned API incompatibility. You would have to try installing Developer or Nightly to test and then you should be able to install it via https://addons.mozilla.org/en-US/firefox/addon/auto-reader-view/ .

reaganch commented 6 years ago

Gotit. Will unfortunately not be able to test the addon this week since I'll be traveling. Will give it a spin next week and report here. Thanks again for putting this together!

reaganch commented 6 years ago

Just updated to Firefox v58.0b4 on Linux Mint 18.2 and installed the addon. Opening the news article http://www.aljazeera.com/news/2017/11/uk-leaders-academics-raise-alarm-saudi-crisis-171118195237495.html and clicking on the "Auto Reader Mode" button followed by "Enable" instantly makes the article appear in reader mode, but opening it again results in it appearing in regular mode instead of reader mode, although a green check mark appears on the "Auto Reader Mode" button. Clicking on the "Auto Reader Mode" button now allows the option of disabling on the domain.

pmarchwiak commented 6 years ago

Thanks, I was able to reproduce this. I'll let you know when I have a fix ready.

Xpider commented 3 months ago

你的邮件我已收到~ 杨鹏飞