pmariglia / showdown

A Pokemon Showdown Battle Bot written in Python
GNU General Public License v3.0
239 stars 174 forks source link

Pokemon nicknames #188

Open BigDawgJamal opened 3 months ago

BigDawgJamal commented 3 months ago

Howdy!

So im not really that well-versed in coding, but for some reason when you load up the bot with a team, it dosnt include the different nicknames that you have set for them. Ive been trying to mess around with a lot of it for quite a few hours and I got differeing but mostly lacking results, since my coding experince is near to none. It might even just be a problem I have caused myself, then again, I wouldnt know. Im assuming its a feature of the bot since the team_converter, has both "name", and "species".

Could you point me in the right directions? Or maybe test out the bot yourself, to see if the problem exists for you and not just me?Either way, thanks for your hard work on the bot!!

Edit: Sorry for the many questions. But I was also wondering if there was a way of changing or removing the autochat feature? Edit: It also does not make them shiny. Im not really sure what the issue is, Is there another specific way the information in the "team" file has to be for it to read it correctly?

pmariglia commented 3 months ago

Thanks for the issue. Yes this is a problem as I did not write a perfect team parser since I did not care about nicknames when testing.

This function is what would need to change to support allowing nicknames to be pased from the export string.

And then this function would need to change to allow the nickname to be put into the packed format that PokemonShowdown reads.

Here are some docs from PS on how these formats look like..