search

pmario / file-backups

File Save & Backup Utility For TiddlyWiki
https://pmario.github.io/file-backups
75 stars 7 forks source link

Error detecting itself? #11

Closed furicle closed 5 years ago

furicle commented 6 years ago

image

After a complete system reboot (Windows Updates)

Note this is with version 0.1.2 - may no longer apply Only one copy in add-ons, and it doesn't show as disabled?

pmario commented 6 years ago

That's interesting. .. I'll check :)

pmario commented 6 years ago

Could you reproduce the issue with the latest version?

I'll post 0.3.0 soon. Would be interesting, to see what's going on there.

pmario commented 6 years ago

I don't know, how to reproduce this message?

Do you use TWclassic?

pmario commented 6 years ago

I did see this once, ... but I can't replicate it properly. ...

frankJMH commented 6 years ago

Same problem here, same error message on opening the TW file :-( All worked fine up to March 3rd (date of my last save and backup), no idea what changed then. I am using TWclassic. Reverted back to File Backups 0.3.1 but that has the same problem.

pmario commented 6 years ago

All worked fine up to March 3rd (date of my last save and backup), no idea what changed then.

March 3rd ... nothing happened from the plugin side. .. Did you try to restart the browser?

pmario commented 6 years ago

@frankJMH ... Do you know, what you did, when the info happened

frankJMH commented 6 years ago

hello pmario, on 3rd March from my end nothing changed that I remember (no Win or FireFox updates, I have the latest FF 58.0.2 (64-bit)) In the meantime I removed all extension from Firefox, refreshed Firefox and when that didnt help also uninstalled +reinstalled Firefox with only the "File Backups" plugin -but unfortunately the problem remains..

pmario commented 6 years ago

That's strange. ... Can you test the following steps.

You should NOT find something. .. If you do, we have a problem

frankJMH commented 6 years ago

actually I found "tiddlyfox-message-box", in the last line..

frankJMH commented 6 years ago

..checked a few more backed up files -and found one earlier on 3rd March that opens without problems while "File Backups" enabled and does not contain "tiddlyfox-message-box". The next backup raises the problem and contains "tiddlyfox-message-box".. Have we found the problem here?

pmario commented 6 years ago

.. Have we found the problem here?

Yes. I'm not sure, how it happens, but it seems a temporary structure has been saved. ...

The tiddlyfox-message-box is used to communicate between TW and the AddOn. .. It is created at startup. BJ and I did implement a check, that allows us to detect each others AddOn. ...

frankJMH commented 6 years ago

OK, did above. Now my corrected TW file loads fine while "File Backups" enabled.

"File Backups" works, however after saving a modified tiddler it opens the "save as" window and asks permission to overwrite itself. The same happens with the next backup file.

Note that I do have a good backup, so I can also recover manually from there. But I'm also happy to continue debugging, let me know what your prefer.

pmario commented 6 years ago

You have to have your files saved to the browser "Downloads" directory or a sub-directory. We are not allowed anymore to freely save where we want.

pmario commented 6 years ago

You may need to do a browser restart in between, so every tab and the addon are re-initialized. ... Just to be sure

pmario commented 6 years ago

@furicle ... Did you have a problem with TWclassic or TW5??

frankJMH commented 6 years ago

Restarted my PC, but the "save as" dialogue continues coming up. The location of my TW file (and the "twBackups" under it) is the same as when all worked fine, and in the "Downloads" folder (via a hard link to another location). I tested with the file in "Downloads" proper (without hardlink) and again the same problem. In fact, in this case the first time it "save as" to "beakon.tmp.html".

frankJMH commented 6 years ago

Found it: its because a Firefox setting "Always ask you where to save files". If I change that to "Save files to: Downloads" it all works fine (guess that changed because of Firefox reinstall).. So, now I continue using your excellent tool! Thanks for the help.

ppmt commented 5 years ago

I will write here since the issue is still open. I am using your plugin and until today I had no issue with it. I use it to save and backup to of my own tiddlywiki.

Tonight I downloaded a copy of mGSD (old MonkeyGTD) and copied in the same place as the other wiki I have.

For some reason it complains of detecting another instance of the plugin

pmario commented 5 years ago

The next version of the plugin will have a better check. ... That's why it's still open.

@ppmt Did you check this: https://github.com/pmario/file-backups/issues/11#issuecomment-372019791 info?

ppmt commented 5 years ago

Hello. I will wait for the next version then :)

And no I had not seen this specific message. So I followed it and the error message has disappeared which is good but instead each time I open the file I get the following window that pops up

It appears that this TiddlyWiki has been incorrectly saved. Please see http://www.tiddlywiki.com/#Download for details

once I click OK it seems fine and the file loads. I can live with that so all is good!

pmario commented 5 years ago

once I click OK it seems fine and the file loads. I can live with that so all is good!

I'm not sure here. ... How did you download the mGSD?

You know, there is a TW5 version which is called: cardo.wiki

ppmt commented 5 years ago

I downloaded it from the website: http://mgsd.tiddlyspot.com/#mGSD

I was not aware of Cardo.wiki...will check

Thanks

pmario commented 5 years ago

IMO should be fixed with V0.3.10-beta pls test: https://github.com/pmario/file-backups/releases/tag/V0.3.10-beta

pmario commented 5 years ago

Got feedback at: https://github.com/pmario/file-backups/issues/28#issuecomment-525700584

Pretty sure we found all the problems now. closing this one.

Mark-Booth commented 4 years ago

This just happened to me today.

Following advice earlier, I closed Firefox, edited the tiddlyfox-message-box out of the html, restarted Firefox and the error went away. I then made a trivial change to the tiddlywiki, saved it, tried to reload the page to verify that the changes had been saved, and the "another plugin" error came back.

Looking at the source again I see the tiddlyfox-message-box was back in the file.

Firefox 68.3.0esr, File Backups 0.3.5, TiddlyWiki cassic

Mark-Booth commented 4 years ago

Installing File Backups 0.3.10 beta, I can confirm that it no longer pops up the message box, but it doesn't remove the tiddlyfox-message-box div from tiddlywiki html file on save however.

Editing the file manually, then saving again doesn't add it back in though.

How far are we from 0.3.10 coming out of beta and being uploaded to the Mozilla add-on store? It would be nice if the update were done automatically.

Thanks for your work on this addon, and if there is anything I can do to help getting 0.3.10 out of beta, please ask.

pmario commented 4 years ago

@Mark-Booth Hi, Thanks for the info. I'll try to activate 0.3.10 very soon. I didn't get much feedback on problems with 0.3.5. ... that's why I did hesitate to change it.