Dtella should not echo commands back to main chat

[GoogleCodeExporter]

Dtella should not echo valid commands back to the main chat. This is
especially confusing for newbies who may not realise that nobody else will
be able to read it, or Dtella's output.

Instead, Dtella should echo the command as if sent to *Dtella in a private
message, and output everything resulting from the command through private
message.

Original issue reported on code.google.com by infinity0x@gmail.com on 2 Mar 2009 at 6:00

[GoogleCodeExporter]

I further suggest that an invalid command as sent to dtella through main chat 
should
not be sent on as a proper message

Specifically, there have been loads of users type things like !share (and our
specific command !stuff with many miss-spellings to access the newstuff list) 
where
an invalid command is sent on as a main chat message.

I dont think it is unreasonable to assume that any message started with a ! is
supposed to be a command wether the user can type or not.

As a result, I dont think its unreasonable to prevent any message starting with 
a !
from becoming part of main chat, irrespective of if it a valid command or not.

Original comment by andy...@gmail.com on 2 Mar 2009 at 7:37

[GoogleCodeExporter]

I don't think we will change this in the main line code as many networks have 
custom
IRC bots and other commands that use the !command notation. Simply having the 
Dtella
client eat all of these would break many of these scripts.

If a valid command is sent to the client, it is only echoed locally and not 
sent on
to other users (or at least that is what it is supposed to be doing)

Original comment by jacob.feisley on 7 Mar 2009 at 6:45

• Added labels: Type-Enhancement, Priority-Low, Component-Client
• Removed labels: Type-Defect, Priority-Medium

[GoogleCodeExporter]

Oh i guess i see what you mean there... You don't want it to even echo locally 
in the
main chat as it can confuse people.

I still think it easier to just have it echo back to the user there because
otherwise, they type a command and a PM window pops up and then there are 
different
commands for that window (ones without the ! )

In the end, I still think the current methodology works the best.

Original comment by jacob.feisley on 7 Mar 2009 at 6:53

[GoogleCodeExporter]

I think sending a response to a PM window would be a bit annoying.  It might 
make
sense to echo back the command you type in such a way that it doesn't look like 
a
chat message, though.

Instead of:

  <Paul> !udp
  <*Dtella> Dtella's UDP port is currently ...

It could show something along the lines of:

  <*Dtella> You commanded: !udp
  <*Dtella> Dtella's UDP port is currently ...

Original comment by sparkm...@gmail.com on 7 Mar 2009 at 7:00

[GoogleCodeExporter]

Changed in r567 .

But I'm not going to use PMs by default; that's too annoying.

Original comment by sparkm...@gmail.com on 7 Mar 2009 at 7:30

• Changed state: Fixed

[GoogleCodeExporter]

er, "yoinked"? make it something more explicit, like "Received command:" or 
something

Original comment by infinity0x@gmail.com on 7 Mar 2009 at 11:32

[GoogleCodeExporter]

Yea, Paul, what the heck is "yoinked" :)

Original comment by jacob.feisley on 7 Mar 2009 at 1:02

[GoogleCodeExporter]

Changed again in r567 because "yoinked" did not seem to make much sense.

Original comment by feisley@gmail.com on 7 Mar 2009 at 1:27