pmarks-net / ipvfoo

Display the current page's IP version and addresses
Apache License 2.0
555 stars 51 forks source link

Hi-Res Graphics #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use IPvFoo on a Hi-Res Device (e.g. MacBook Pro with Retina Display)

What is the expected output? What do you see instead?
Expected: sharp hi-res graphics
Instead: pixelated graphics

What version of the product are you using? On what operating system?
Chrome 28.0.1500.11 / OS X

Please provide any additional information below.
Would be great if IPvFoo would use hi-res graphics. Chromes add-to-bookmarks 
star does and is directly next to IPvFoo's 6 (or 4) which looks quite ugly 
compared to it. You probably just have to make the graphics twice the size. Or, 
even better, you could use actual text instead of graphics and let Chrome take 
care of the correct rendering.

Original issue reported on code.google.com by ruben.de...@gmail.com on 18 May 2013 at 6:01

Attachments:

GoogleCodeExporter commented 9 years ago
I definitely don't want to render as text in 19x19 mode, since I had to draw 
the little 4 and 6 by hand to make them fit correctly.

I think I'll just make some new sprites for 38x38 mode.

For future reference, the big numbers are:
- Drawn in Gimp
- Arial Bold
- Size 22px
- The 4 is slightly truncated.

This issue might be helpful:
https://code.google.com/p/chromium/issues/detail?id=138025

I should find out if there's a way to ask Chrome which DPI is active, to avoid 
the overhead of rendering multiple images.

Original comment by sparkm...@gmail.com on 18 May 2013 at 8:03

GoogleCodeExporter commented 9 years ago
Ruben: would you mind attaching a screenshot of IPvFoo's popup window?  I'm 
wondering how that looks in HiDPI mode.

Original comment by sparkm...@gmail.com on 18 May 2013 at 8:33

GoogleCodeExporter commented 9 years ago
there you go:

Original comment by ruben.de...@gmail.com on 18 May 2013 at 9:21

Attachments:

GoogleCodeExporter commented 9 years ago
I'm going to leave the padlock icons alone for now.

I don't have a HiDPI-capable system to test with, so could you let me know if 
this works for you?

- Download the attached .crx file
- Go to chrome://extensions/
- Drag the file from your file manager to Chrome

You can remove it when you're done, since it installs alongside the Web Store 
version.

Original comment by sparkm...@gmail.com on 19 May 2013 at 1:25

Attachments:

GoogleCodeExporter commented 9 years ago
Ah, I was able to test it by forcing HiDPI mode on a Chromebook.

Original comment by sparkm...@gmail.com on 19 May 2013 at 2:27

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in 1.0.22

Original comment by sparkm...@gmail.com on 19 May 2013 at 2:30

GoogleCodeExporter commented 9 years ago
Looks great, thank you!

Original comment by ruben.de...@gmail.com on 19 May 2013 at 8:11