pmaxted
commented
3 years ago Dear Jayshil, I would be very happy for you to put in a pull request. This is one of the open issues for pycheops, and I will not get a chance to look at it myself anytime soon. When I get the pull request, I will ask some of the other pycheops users to take a look at your implementation, so there will be a bit of a delay before we merge it into the main branch, and we may want to "tweak" it a bit first. I'll keep you informed of our progress. Regards, -Pierre Maxted
From: Jayshil A Patel @.> Sent: 25 November 2021 14:35 To: pmaxted/pycheops @.> Cc: Pierre Maxted @.>; Mention @.> Subject: [pmaxted/pycheops] Changing the input file formats so that it can accepts files from other sources (Issue #249)
Dear @pmaxtedhttps://github.com/pmaxted
I am currently working on a module called pycdatahttps://github.com/Jayshil/pycdata, which can accept/download lightcurves from other sources (mainly CHEOPS PSF photometry from PIPEhttps://github.com/alphapsa/PIPE, but also from TESS, Kepler/K2) and return files which pycheops can read. However, this is having file naming issues since pycheops can read only those files which have names in a certain format (resembling CHEOPS file idshttps://github.com/pmaxted/pycheops/blob/4b10a8d35fe8899d0adab07e39796a5eddfbe4ea/pycheops/dataset.py#L84). At the moment, I made it work by giving aliases, but it would be much better if pycheops can read other file formats. If you want, I can open a pull request implementing such changes. Let me know.
Regards, Jayshil
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/pmaxted/pycheops/issues/249, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEUQLXW4SHAWQPPQFNPUGLLUNZCTXANCNFSM5IYWCLTQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Please consider the environment before printing this email.This email and its contents may be legally privileged and /or confidential.If it has come to you in error you should not copy or show it to anyone; nor should you take any action based on it, other than to reply to the sender to notify them of the error immediately and to then delete the email from your inbox and deleted items. Keele University staff and students are required to abide by the University's IT Policies when sending and receiving email. Keele University email is hosted by a cloud provider and may be stored outside of the UK.
Jayshil
Dear @pmaxted
I am currently working on a module called pycdata, which can accept/download lightcurves from other sources (mainly CHEOPS PSF photometry from PIPE, but also from TESS, Kepler/K2) and return files which pycheops can read. However, this is having file naming issues since pycheops can read only those files which have names in a certain format (resembling CHEOPS file ids). At the moment, I made it work by giving aliases, but it would be much better if pycheops can read other file formats. If you want, I can open a pull request implementing such changes. Let me know.
Regards, Jayshil