search

pmbuko / KerbMinder

⚠️ This project is no longer maintained ⚠️ KerbMinder is a tool for Mac OS X that keeps a logged-in user's Kerberos ticket current by attempting to renew or refresh it automatically any time the network state changes.
http://yourmacguy.wordpress.com/kerbminder/
54 stars 6 forks source link

fixed exception if no domain available #5

Closed pmbuko closed 9 years ago

codecov-io commented 9 years ago

Current coverage is 46.25%

Merging #5 into master will decrease coverage by -0.16% as of 09c4fbe

@@            master      #5   diff @@
======================================
  Files            1       1       
  Stmts          293     294     +1
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            136     136       
  Partial          0       0       
- Missed         157     158     +1

Review entire Coverage Diff as of 09c4fbe

Powered by Codecov. Updated on successful CI builds.

ftiff commented 9 years ago

Good catch ! However I think this should not fail, that's why I didn't catch this error. Looks like you are bound to AD, but get an output we can't apply this regex on. Can you try to run dscl /Search read /Users/[user] on your Mac ?

For me, we should either modify the regex or catch this another way. Don't you think ?

pmbuko commented 9 years ago

The regex matches [username]@[sub.domain.com], where username can have dot or dash. I am bound to AD, but the AuthenticationAuthority portion that included my domain is does. It appear in the search unless the domain is reachable.

-- Peter (from phone)

On Nov 3, 2015, at 5:38 AM, Francois Levaux-Tiffreau notifications@github.com wrote:

Good catch ! However I think this should not fail, that's why I didn't catch this error. Looks like you are bound to AD, but get an output we can't apply this regex on. Can you try to run dscl /Search read /Users/[user] on your Mac ?

For me, we should either modify the regex or catch this another way. Don't you think ?

— Reply to this email directly or view it on GitHub.