search

pmckeetx / docker-nginx

74 stars 65 forks source link

Update node version to 14 #7

Open jessewang-arvatosystems opened 1 year ago

jessewang-arvatosystems commented 1 year ago

docker compose fails to finish with node version 12.18.2 as @testing-library/dom@9.3.1 will throw an error expecting a version >=14.

Will need to update the blog to reflect this as well: https://www.docker.com/blog/how-to-use-the-official-nginx-docker-image/

Also... docker-compose up was not a valid command for me, I used docker compose up instead.

newtob commented 1 month ago

Yes! Great start. Please investigate.

I just tried this update but it doesn't get past the existing error for me. Error in issue #9 #0 48.87 error @testing-library/dom@10.3.0: The engine "node" is incompatible with this module. Expected version ">=18". Got "14.21.3"

I upgraded node to 22 and still the same error. But then I did the following for it to work:

replace "start": "react-scripts start" by "start": "react-scripts --openssl-legacy-provider start" replace "build": "react-scripts build" by "build": "react-scripts --openssl-legacy-provider build"