search

pmclanahan / django-celery-email

A Django email backend that uses a celery task for sending the email.
BSD 3-Clause "New" or "Revised" License
477 stars 110 forks source link

Celery 4.x support #43

Closed barseghyanartur closed 7 years ago

barseghyanartur commented 7 years ago

Are there plans for supporting Celery 4.x in nearest future? If so, could you give an estimation?

pmac commented 7 years ago

I don't really have plans on working on this. I've not used it personally in years. I'm happy to review and merge pull requests however, so if you or someone else gets the time please let me know.

FYI: pmac is my main account now, pmclanahan is an alternate I use for some orgs

barseghyanartur commented 7 years ago

@pmac:

Thanks for the quick reply.

georgmzimmer commented 7 years ago

I may be needing it on a celery 4 project soon, if so, i'll take a look at it. Any idea what isn't working?

barseghyanartur commented 7 years ago

@georgmzimmer:

Are you upgrading from old Django/Celery stack?

georgmzimmer commented 7 years ago

No, new project.

barseghyanartur commented 7 years ago

@georgmzimmer:

Ok. No idea what didn't work. I was trying to replace an old stack (Celery 3.x, django-celery, django-celery-transactions, django-celery-emails, kombu) with upgraded versions (upgrade Celery to 4.x, wipe out django-celery, replace django-celery with new apps). It seemed to work until a point, when I had to touch a way too many things that didn't work (risk going over the budget). So I just stopped.

I'll stay subscribed to this issue and hopefully over a year or so I can try again. :)

poxip commented 7 years ago

I'm working on upgrading it to the latest Celery, will send a PR when I finish.

poxip commented 7 years ago

PR https://github.com/pmclanahan/django-celery-email/pull/44

barbossa commented 7 years ago

@pmac can you merge PR #44 to master? I realy need this! Thanks!

@poxip thanks for adding support for Celery 4.x!

pmclanahan commented 7 years ago

I can. Might not get to it until Monday though. That soon enough? -- -- pmac

barbossa commented 7 years ago

Monday will be okay. @pmclanahan thanks for quick reply.

pmac commented 7 years ago

44 is now merged and v 2.0.0 is now released on PyPI. Thank you very much @poxip 🎉