search

pmclanahan / django-celery-email

A Django email backend that uses a celery task for sending the email.
BSD 3-Clause "New" or "Revised" License
477 stars 108 forks source link

Support for Django 3.x #66

Closed philippbosch closed 4 years ago

philippbosch commented 4 years ago

This change is a breaking change because it removes support for Python 2.x so a major release would be necessary.

The Django team suggests to drop support of Django versions prior to 2.2 in their release notes.

endersonmenezes commented 4 years ago

It's correct :) I liked! Need review a Redme, because it drops python 2.7 support, but works fine in Django 2.2

endersonmenezes commented 4 years ago

image Fail only Python 2.7 :)

endersonmenezes commented 4 years ago

Need update on README now.

This version requires the following versions: Python >= 3.5 Django 1.11, 2.1, and 2.2 Celery 4.0

philippbosch commented 4 years ago

@endersonmenezes voilà!

pmac commented 4 years ago

Should also update the tox.ini to remove Python 2.7 and Django 1.11, and add Django 3.0.

philippbosch commented 4 years ago

@pmac oh, right. just updated this. do you want me to also add to the changelog? if so, do you agree that we need a 3.0 for these changes?

pmac commented 4 years ago

If you don't mind updating the changelog that would be helpful, yes. And I do agree that this seems worthy of a major version number bump.

philippbosch commented 4 years ago

@pmac did some tweaks and clean-up, tests are passing, updated the changelog. i would say everything is in place for a release. let me know if anything is missing.

pmac commented 4 years ago

Just a couple of small tweaks and then I think we're ready. Thanks again!!

philippbosch commented 4 years ago

oh yes, thanks for catching these. fixed now.

pmac commented 4 years ago

🎉

pmac commented 4 years ago

Release is up on PyPI. Thanks all! 🎉

https://pypi.org/project/django-celery-email/3.0.0/