pmderodat / ada-toml

TOML parser for Ada
Other
31 stars 5 forks source link

Make TOML.ads preelaborable #1

Closed mosteo closed 5 years ago

mosteo commented 5 years ago

Non-preelaborable IO moved to TOML.Text_IO

This allows to keep certain things as they are in Alire, and I guess is generally advantageous for a library to have its core functionality as preelaborable.

mosteo commented 5 years ago

I thought I had nailed the independent PR thing but for some reason the other PR is showing here too. I hope that wasn't too confusing (and sorry). Will fix these things ASAP

pmderodat commented 5 years ago

No problem :-) In Gitub, a PR is tied to a source branch: if you update the source branch (for instance pushing more commits), it will automatically update the corresponding PR.

mosteo commented 5 years ago

Yup, I see my mistake was to make the first PR from master. Will remember for the next time.

mosteo commented 5 years ago

I actually opened the table-merge PR in parallel before seeing your comments XD

I guess if I force-push master to the first commit in this one it should clean history here? I'm going to try.