search

pmed / v8pp

Bind C++ functions and classes into V8 JavaScript engine
http://pmed.github.io/v8pp/
Other
901 stars 121 forks source link

Use __clang__ string format when compiling using Clang + MSVC. #150

Closed wflohry closed 3 years ago

wflohry commented 3 years ago

Typename deduction fails when using Clang with MSVC build files, since Clang adds the _MSC_VER preprocessor directive.

This PR fixes this by adding another check for !defined(__clang__); defining __clang__ in the user's build script when allow proper typename deduction.

pmed commented 3 years ago

Super, thanks a lot!