pmed / v8pp

Bind C++ functions and classes into V8 JavaScript engine
http://pmed.github.io/v8pp/
Other
887 stars 119 forks source link

Fix some gcc warnings #164

Closed YarikTH closed 2 years ago

pmed commented 2 years ago

I've actually fixed some warnings earlier in commit c145f120eda9bbedd6b44cc263aad36a292731cf Pushed it just now.

YarikTH commented 2 years ago

It seems that your commit addresses all the cases that I handled here, but mostly in a different ways. Never heard about the comment "// fallthrough". Good to know.