Fix test that fails when v8 is built with is_debug and dcheck_always_on

pmed / v8pp

Bind C++ functions and classes into V8 JavaScript engine

http://pmed.github.io/v8pp/

Other

901 stars 121 forks source link

Fix test that fails when v8 is built with is_debug and dcheck_always_on #175

Closed arghness closed 2 years ago

arghness commented 2 years ago

There were a couple of v8 DCHECK assertions related to the isolate not being set in the test when v8::ScriptOrigin needed it, and the Isolate not being cleaned up before shutting down v8. Tested with v8 9.4.146.22.

pmed commented 2 years ago

Hi Alex,

Thanks a lot! v8::Isolate in test_context should definitely be disposed manually, since it is not owned by the v8pp::context instance.

pmed commented 2 years ago

Hi Alex,

I've fixed macOS build on GitHub Actions (issue #176) Could you please rebase your branch on the recent master?

arghness commented 2 years ago

Rebased and squashed.

pmed commented 2 years ago

Great, thank you!