search

pmed / v8pp

Bind C++ functions and classes into V8 JavaScript engine
http://pmed.github.io/v8pp/
Other
901 stars 121 forks source link

Deprecated `VisitHandlesWithClassIds` has been removed in v8 10.5.X #181

Closed jcmonnin closed 1 year ago

jcmonnin commented 2 years ago

It has been removed in https://github.com/v8/v8/commit/4cf204da0a7c59f476bc2ea6622d897f660e22d0

v8pp uses it in function.hpp: external_data::destroy_all

It does't look trivial to replace it...

Aincvy commented 2 years ago

Is there a plan to fix this ?

pmed commented 2 years ago

Hi,

I haven't look to this yet. PR are welcome, if you have an idea how to fix it.