Build fails on systems with newer ICU

pmed / v8pp

Bind C++ functions and classes into V8 JavaScript engine

http://pmed.github.io/v8pp/

Other

898 stars 120 forks source link

Build fails on systems with newer ICU #29

Closed vasilevp closed 7 years ago

vasilevp commented 7 years ago

Not really a big issue and I understand that the library was not tested on non-Ubuntu setups, but commit 5770abbe removed linking with icui18n and icuuc shipped with V8 which causes linking errors on systems with ICU 5.7 (such as Manjaro I'm currently on).

Building with V8 obtained from build-v8.sh and re-adding -licuuc -licui18n to LIBS works fine.

pmed commented 7 years ago

@exploser thanks! I've added these ICU libraries into the Makefile.