pmed / v8pp

Bind C++ functions and classes into V8 JavaScript engine
http://pmed.github.io/v8pp/
Other
898 stars 120 forks source link

shared_ptr branch #57

Closed jcmonnin closed 7 years ago

jcmonnin commented 7 years ago

Hi,

I'm using the shared_ptr branch. I was trying to merge this branch with the latest master, but there are heavy conflicts that I don't know how to resolve. What is the plan for shared_ptr? I think this is a very useful feature. It would be great if this could be supported officially.

pmed commented 7 years ago

Hi Jean-Claude,

Yes, there may be conflicts with master in the shared_ptr branch. I plan to merge it into the master, but at this moment I have no spare time to do it.

Sure, this feature might be useful for other library users, so it is at the top of my todo list.

пн, 6 марта 2017 г. в 7:54, Jean-Claude Monnin notifications@github.com:

Hi,

I'm using the shared_ptr branch. I was trying to merge this branch with the latest master, but there are heavy conflicts that I don't know how to resolve. What is the plan for shared_ptr? I think this is a very useful feature. It would be great if this could be supported officially.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pmed/v8pp/issues/57, or mute the thread https://github.com/notifications/unsubscribe-auth/ABEgUiM5fmD3F3nkta2zf7b8MmU-m8J6ks5ri5GWgaJpZM4MTuUZ .

-- Sincerely, Pavel

jcmonnin commented 7 years ago

Thanks for the reply. It's good to know that the shared_ptr functionality will be part of v8pp eventually. I understand that the spare time to work on such a project is limited.

pmed commented 7 years ago

Merged to master in 271e12d