Added set_static function to object_registry

pmed / v8pp

Bind C++ functions and classes into V8 JavaScript engine

http://pmed.github.io/v8pp/

Other

901 stars 121 forks source link

Closed atvise closed 5 years ago

atvise commented 6 years ago

To be able to set static variables this function is introduced. e.g.: MyClass.MY_STATIC_VARIABLE

This solves issue: #84

pmed commented 6 years ago

Hi,

Thanks for the PR. Could you please add a test case for this change, to ensure it works as expected?

atvise commented 6 years ago

Hi,

You're welcome! Yes will do!

atvise commented 6 years ago

I really don't know why the tests are failing with my v8 version 6.4.388 the tests are working ...

pmed commented 6 years ago

The test fails on Windows with V8 versions 6.6, 6.9:

test_class error: check failed: X::my_static_const_var expected: '42' actual: '123'

Adding ReadOnly property attribute for DefineOwnProperty() seems doesn't work for some reason.

pmed commented 5 years ago

Hi @atvise,

I've fixed that test case for static var binding in the class and merged your changes to the master branch. Thank you!

Happy New Year!