search

pmelchior / des-exp-checker

Crowdsourced image quality control for the Dark Energy Survey
MIT License
9 stars 2 forks source link

Loading of unavailable image causes freeze #41

Closed pmelchior closed 10 years ago

pmelchior commented 10 years ago

When the viewer request an image that the server doesn't know, db.php will return

name: "getImage.php?name="

instead of a Server Error, so that the $.post function cannot execute the .fail() part. Update db.php and check that failure triggers a message popup to explain that to the user.

SanchitAggarwal commented 10 years ago

While understanding the logic of the viewer I was facing same problem, I thought it was due to my limited access to fitsdomain.

pmelchior commented 10 years ago

No, you should be able to access the fitsdomain just like we do it.

SanchitAggarwal commented 10 years ago

Hi Peter, The fitsdomain was same. I guess there is delay in getting the file downloaded (Hence timeout in Viwer.html) from the fitsdomain when getImage.php is called. Am I missing something ?

For the time-being I have downloaded one experiment image folder(DECam_00157875) from fitsdomain and hosted it in my local folder. I have deleted entries in files.runs table other than DECam_00157875. Now I am able to see the image, but the drop-down for problems is not displayed.

pmelchior commented 10 years ago

Do you have Server-Side Includes activated? In order to avoid replicating the dropdown on several pages, the html is loaded from problem_selector.shtml

SanchitAggarwal commented 10 years ago

Yes , SSI are activated, I was able to see it earlier before the latest changes. I am looking into the error.

pmelchior commented 10 years ago

The latest update introduces a change to the login requirement. It's not needed anymore to open the viewer, but one cannot mark any problems. You should see the problem dropdown and get a modal that tells you to log in if you're not logged in yet. I've tested it on chrome and safari and it works as intended. First thing to check is to see if the dropdown is loaded into the html file at all or if it is just hidden.

SanchitAggarwal commented 10 years ago

It got solved, the files in my root directory didn't had executable permissions.