pmelchior / des-exp-checker

Crowdsourced image quality control for the Dark Energy Survey
MIT License
9 stars 2 forks source link

Colored problem markers for respective category #51

Open SanchitAggarwal opened 10 years ago

SanchitAggarwal commented 10 years ago

Implement color markers for each category of problems and ability to remove the marks.

Needs: 1) Addition of collapsable nodes(squared box) for each mark on the canvas. 2) Change in the marker imprint module, instead a box will be added on the clicked pixel. 3) Table/ JSON to store different color for respective problem categories.

I am using JSPlumb to implement this http://jsplumbtoolkit.com/demo/home/dom.html. Any suggestions ?

pmelchior commented 10 years ago

I don't think you need a full-blown graph library for the functionality. I'm thinking of something much lighter, such as http://qtip2.com/demos. If you check out the "Positioning" section, there is a good example. I'm thinking of inserting a SVG shape (say a small "X" or something similar) onto of the image for each problem mark (there is already a canvas to hold these shapes), and then to attach a qtip to it. The color of the "X" would depend on the problem category, so provide a quick visual clue that works even without the tooltip.

The difficulty is to insert & remove the qtips on the loaded page whenever the user marks a problem, or when he loads the previously known problems.

SanchitAggarwal commented 10 years ago

I have added the patch for color markers with qtips on my experimental branch. Kindly review.

pmelchior commented 10 years ago

I will go through your changes, but not before Wednesday.

pmelchior commented 10 years ago

I had a first look at your changes today. That's a good start. I like the way the "x" on the image is linked to the qTip. Also, the different colors are nice. I would like the "x" to be somewhat larger (maybe 150% of what you currently have) and the colors to be somewhat brighter, but this is something we can easily fix later.

I have some comments regarding the general setup and your work here. They're not directly tied to specific aspects of the code, so I'll comment here.