search

pmelchior / des-exp-checker

Crowdsourced image quality control for the Dark Energy Survey
MIT License
9 stars 2 forks source link

False Positive/Negative Toggle #53

Closed kadrlica closed 10 years ago

kadrlica commented 10 years ago

DESDM would find it helpful to be able to select on false positives vs false negatives for each artifact category. The idea would be a positive/negative toggle button (like the "Toggle Scaling" and "Toggle Mask") that would cause subsequent problem markers to be flagged as positive/negative.

pmelchior commented 10 years ago

I understand the wish for it, but I'm very skeptical that can be realized in a way that doesn't confuse the user. The toggle is likely to do just that because you now have to remember what you want to mark and whether this is positive/negative. What's more: the toggle will remain in its chosen state, which means that the user has to undo the selection afterwards.

While we can do something like false-posititive collection internally rather easily (we can just use a minus for the problem code in the database), we need a solution for the user interface that is very clear and intuitive. Maybe we can integrate this into the new tooltip marks we get from #51. I'm thinking of a extra icon to click on inside of tooltip that indicates a false-positive.

kadrlica commented 10 years ago

I understand the concern. Maybe tooltips is the right approach (I have to admit that I don't know what these will look like), but I'm not sure that the two examples given are grounds enough for rejecting the toggle idea. The toggle could reset to it's default state for each new image. The default state of the toggle would be false negative (i.e., the current state of affairs). Therefore, if the user never touches the button, they never see a difference.

pmelchior commented 10 years ago

I think the better way is a button that stays "locked" after clicked once but only as long as the same problem category is selected. So, the workflow would be to select a category, the button appear next to the selector, one would click it or not, and it would only apply to the next mark. Then, it's effectively stateless, and that was my main concern. I've just freed some space next to the problem selector, so that should be simple.

kadrlica commented 10 years ago

Sounds reasonable.