search

pmelchior / des-exp-checker

Crowdsourced image quality control for the Dark Energy Survey
MIT License
9 stars 2 forks source link

links to images from tutorial don't work #58

Closed esheldon closed 10 years ago

esheldon commented 10 years ago

I just get "file missing"

pmelchior commented 10 years ago

I had it for a little while, but now the problem has disappeared. Doesn't leave the most trusting feeling, but I can't see anything wrong with the code. Please confirm it's OK now.

esheldon commented 10 years ago

Nope, not working for me. I'm using the dev site.

kadrlica commented 10 years ago

Works for me. Images appear on the tutorial page and link to viewer.

esheldon commented 10 years ago

Images appear for me, but if I click one of the images in the tutorial I get the error. It doesn't load in the view but instead gives the error.

On 7/3/14, kadrlica notifications@github.com wrote:

Works for me. Images appear on the tutorial page and link to viewer.

Reply to this email directly or view it on GitHub: https://github.com/pmelchior/des-exp-checker/issues/58#issuecomment-47975786

Erin Scott Sheldon Brookhaven National Laboratory erin dot sheldon at gmail dot com

pmelchior commented 10 years ago

Erin, it happened to me too, but then stopped. I will ask some other people to test it, but I don't see a reason for it in the code. In the case of failure, the database query comes back empty without error, I just don't get why.

kadrlica commented 10 years ago

Ok, I think I diagnosed the issue a bit more. If you go to the main page and select the SVA1 release, then the links should work fine. However, if you select the Y1A1 release, the "File Missing" error will occur. I'm not sure why this is happening, since the links all specify "release=SVA1" explicitly.

pmelchior commented 10 years ago

Aha, that was a key observation. The offending line is 247 in viewer.html and overwrites the release parameter in the URL with the default, which is stored in a cookie. The cookie determines from which release the viewer should normally get its files, but in the case of a direct request that is wrong. Adding a check on the presence of the release in the URL will do.