pmelchior / proxmin

Proximal optimization in pure python
MIT License
109 stars 23 forks source link

Update all proximal operators in place #16

Closed fred3m closed 5 years ago

pmelchior commented 5 years ago

All changes are OK. However, I wonder if we still need to inline change, which is at least somewhat unexpected. We introduced that to allow on-the-fly resizing without interrupting the algorithms in this package, and we're not using this feature any more. The more transparent approach would be to return the modified variable but leave the original intact. Plus, if we actually want to differentiate through those proxes, we couldn't do inline updates either.

So the question here is, should we use this PR to make that change?

pmelchior commented 5 years ago

Ignore request, this should be an independent PR.

fred3m commented 5 years ago

While the other approach would be more transparent there are a few things that we need to consider: