pmelchior / pygmmis

Gaussian mixture model for incomplete (missing or truncated) and noisy data
MIT License
98 stars 22 forks source link

Fix parmap deprecation warnings #19

Closed zeehio closed 2 years ago

zeehio commented 3 years ago

Since parmap 1.5.0, parmap allows to have keyword arguments passed to the function, besides positional arguments.

On that version I (parmap author) had to deprecate pool and chunksize arguments replacing them with pm_pool and pm_chunksize respectively.

parmap changelog:

https://github.com/zeehio/parmap/blob/2640864449afc94fad1e1af32b4ef43ac0a3f80c/ChangeLog#L16

This change was necessary to ensure parmap keyword arguments do not collide with your mapped function arguments. If your named arguments in your function don't start with pm_ you are safe of any future argument I add to parmap (so it's just to avoid potential future problems)

I hope it helps

pmelchior commented 2 years ago

thanks very much for this PR!