search

pmelchior / scarlet

hyperspectral galaxy modeling and deblending
MIT License
50 stars 22 forks source link

made BBox any-dimensional #154

Closed pmelchior closed 4 years ago

pmelchior commented 4 years ago

BBox was inelegant because it implicitly assumed or manually forced all boxes to be in 3D. Now it works in any dimension and simply takes its dimensionality from the contained that defined on at init. The only downside is the loss of the front, back, left, right etc. properties. On the upside, as Fred and I can attest: there isn't universal agreement on what they mean, so I've chosen the python slicing syntax start and stop and made it multi-dimensional.

pmelchior commented 4 years ago

Seems to work now, dunno why...