search

pmelchior / scarlet

hyperspectral galaxy modeling and deblending
MIT License
50 stars 22 forks source link

channel selection before convolution/resampling #217

Closed pmelchior closed 3 years ago

pmelchior commented 3 years ago

This is a fix for an inconsistency in Observation: because the PSFs are defined only for channels that are observed (and that might be fewer than in the model frame), we need to select the proper channels before we convolve/resample in render.

There are minor clean-ups throughout the Observation code, both ordinary and LowRes, plus a few TODO notes, where I see possible improvments.

pmelchior commented 3 years ago

@herjy are you OK with merging the PR?