search

pmelchior / scarlet

hyperspectral galaxy modeling and deblending
MIT License
49 stars 22 forks source link

bug fix_data_box #250

Closed herjy closed 2 years ago

herjy commented 2 years ago

This fixes a bug in the misalignment of multi-resolution images. We actually need to know the bounds of the model frame to build the slices of the renderer.

pmelchior commented 2 years ago

I see. Can you please remove lines 18-20 from renderer.py to prevent this mistake from being repeated. slices should be a part of the derived renderer, not the base class.

When you push the changes, we should get travis to run the test (not sure why it was stuck earlier).

herjy commented 2 years ago

Yeah, I wasn't sure about removing it from the base class, wondering if it could ever be useful (or rather not useless).