search

pmelchior / scarlet2

Scarlet, all new and shiny
MIT License
15 stars 4 forks source link

Change of WCS in multiresolution renderer #76

Closed b-remy closed 2 months ago

b-remy commented 3 months ago

This PR solves #75. So far the multiresolution renderer only worked for aligned WCSs with a scale difference. Now, the code detects WCSs rotations in obs.match() and handles them in obs.render().

pmelchior commented 3 months ago

Where do we stand on this PR?

b-remy commented 3 months ago

I moved get_scale, get_angle and get_sign to frame.py which is indeed cleaner and updated the code accordingly.

I am not sure yet how to handle different sign conventions in the WCS pc, but since it is not so usual to have different sign conventions I am raising an error now. I think this PR can be merged and we can think about how to define resampling coordinates when there is a WCS flip later.