search

pmelchior / scarlet2

Scarlet, all new and shiny
MIT License
15 stars 4 forks source link

Fixes `Frame.from_observations` & `frame.get_sign` #80

Closed b-remy closed 1 month ago

b-remy commented 2 months ago

Looking at #79 , I figured that Observation.render could break if the model frame was initialized with Frame.from_observations, because frame and observations may have different WCSs but the same pixel scale. The ConvolutionRenderer would therefore be used, but frames boxes would not necessarily be the same sizes. This PR fixes it.

I also removed all the numpy dependencies in frame.py and used jax.numpy instead.

b-remy commented 2 months ago

Also rounded the ouput of frame.get_sign fixing #79 . Tests are still passing @pmelchior